fix(linux_introspection): declare pkg-config as buildtool_depend#353
Merged
fix(linux_introspection): declare pkg-config as buildtool_depend#353
Conversation
CMakeLists.txt uses find_package(PkgConfig REQUIRED) to locate libsystemd via pkg_check_modules, but package.xml did not declare pkg-config as a buildtool dependency. On clean buildfarm agents rosdep only installs declared dependencies, so the pkg-config binary was missing and CMake configure failed. Local dev environments typically have pkg-config installed system-wide, which masked the issue. Closes #352
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the ROS buildfarm configuration failure for ros2_medkit_linux_introspection by ensuring pkg-config is installed via rosdep, matching the package’s CMake usage of find_package(PkgConfig REQUIRED) for systemd detection.
Changes:
- Add
pkg-configas abuildtool_dependinros2_medkit_linux_introspection/package.xmlso clean build agents install it before CMake configure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The
ros2_medkit_linux_introspectionpackage fails to configure on the ROS buildfarm becausepkg-configis not installed on clean agents.CMakeLists.txtusesfind_package(PkgConfig REQUIRED)to locatelibsystemdviapkg_check_modules, butpackage.xmldid not declarepkg-configas a build tool dependency.rosdeponly installs declared dependencies, so the binary was missing on the buildfarm while local dev environments have it system-wide, masking the issue.This PR adds
<buildtool_depend>pkg-config</buildtool_depend>to the package manifest sorosdep installpulls it in on clean agents.Issue
Type
Testing
package.xmlstill validates againstpackage_format3.xsd.Hdev__ros2_medkit__ubuntu_jammy_amd64(Humble / Jammy) previously failed withCould NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)atCMakeLists.txt:44. With the new buildtool dep,rosdep installwill installpkg-configbefore CMake runs.Checklist